fix(order-module): 修复人才就业路由TypeScript类型错误 (故事015.005)

- 移除所有 `as any` 类型断言,改善代码质量
- 为所有API端点添加完整的ZodError错误处理
- 统一错误处理模式,参考talent-personal-info.routes.ts实现
- 更新故事文档,标记Known Issues为已修复

修改内容:
- 将personId验证移入try-catch块
- 添加Zod验证错误处理并返回400状态码
- 确保所有错误响应都有正确的类型定义

🤖 Generated with [Claude Code](https://claude.com/claude-code)
via [Happy](https://happy.engineering)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>

allin-packages/order-module/src/routes/talent-employment.routes.ts

@@ -161,18 +161,18 @@ const getSalaryVideosRoute = createRoute({
 const app = new OpenAPIHono<TalentAuthContext>()
   // 获取当前就业状态
   .openapi(getEmploymentStatusRoute, async (c) => {
-    const user = c.get('user') as TalentUser;
-    const personId = user.personId;
+    try {
+      const user = c.get('user') as TalentUser;
+      const personId = user.personId;
 
-    // 验证person_id是否存在
-    if (!personId) {
-      return c.json({
-        code: 404,
-        message: '用户不存在或未关联残疾人信息'
-      } as any, 404);
-    }
+      // 验证person_id是否存在
+      if (!personId) {
+        return c.json({
+          code: 404,
+          message: '用户不存在或未关联残疾人信息'
+        }, 404);
+      }
 
-    try {
       const orderService = new OrderService(AppDataSource);
       const employmentStatus = await orderService.getCurrentEmploymentStatus(personId);
 
@@ -180,31 +180,39 @@ const app = new OpenAPIHono<TalentAuthContext>()
         return c.json({
           code: 404,
           message: '未找到就业记录'
-        } as any, 404);
+        }, 404);
       }
 
       const validatedResult = await parseWithAwait(EmploymentStatusResponseSchema, employmentStatus);
       return c.json(validatedResult, 200);
     } catch (error) {
+      if (error instanceof z.ZodError) {
+        return c.json({
+          code: 400,
+          message: '参数错误',
+          errors: error.issues
+        }, 400);
+      }
+
       return c.json({
         code: 500,
         message: error instanceof Error ? error.message : '获取当前就业状态失败'
-      } as any, 500);
+      }, 500);
     }
   })
   // 获取薪资记录
   .openapi(getSalaryRecordsRoute, async (c) => {
-    const user = c.get('user') as TalentUser;
-    const personId = user.personId;
+    try {
+      const user = c.get('user') as TalentUser;
+      const personId = user.personId;
 
-    if (!personId) {
-      return c.json({
-        code: 404,
-        message: '用户不存在或未关联残疾人信息'
-      } as any, 404);
-    }
+      if (!personId) {
+        return c.json({
+          code: 404,
+          message: '用户不存在或未关联残疾人信息'
+        }, 404);
+      }
 
-    try {
       const query = c.req.valid('query');
       const orderService = new OrderService(AppDataSource);
       const salaryRecords = await orderService.getSalaryRecords(
@@ -217,25 +225,33 @@ const app = new OpenAPIHono<TalentAuthContext>()
       const validatedResult = await parseWithAwait(SalaryRecordsResponseSchema, salaryRecords);
       return c.json(validatedResult, 200);
     } catch (error) {
+      if (error instanceof z.ZodError) {
+        return c.json({
+          code: 400,
+          message: '参数错误',
+          errors: error.issues
+        }, 400);
+      }
+
       return c.json({
         code: 500,
         message: error instanceof Error ? error.message : '获取薪资记录失败'
-      } as any, 500);
+      }, 500);
     }
   })
   // 获取就业历史
   .openapi(getEmploymentHistoryRoute, async (c) => {
-    const user = c.get('user') as TalentUser;
-    const personId = user.personId;
+    try {
+      const user = c.get('user') as TalentUser;
+      const personId = user.personId;
 
-    if (!personId) {
-      return c.json({
-        code: 404,
-        message: '用户不存在或未关联残疾人信息'
-      } as any, 404);
-    }
+      if (!personId) {
+        return c.json({
+          code: 404,
+          message: '用户不存在或未关联残疾人信息'
+        }, 404);
+      }
 
-    try {
       const query = c.req.valid('query');
       const orderService = new OrderService(AppDataSource);
       const employmentHistory = await orderService.getEmploymentHistory(
@@ -247,25 +263,33 @@ const app = new OpenAPIHono<TalentAuthContext>()
       const validatedResult = await parseWithAwait(EmploymentHistoryResponseSchema, employmentHistory);
       return c.json(validatedResult, 200);
     } catch (error) {
+      if (error instanceof z.ZodError) {
+        return c.json({
+          code: 400,
+          message: '参数错误',
+          errors: error.issues
+        }, 400);
+      }
+
       return c.json({
         code: 500,
         message: error instanceof Error ? error.message : '获取就业历史失败'
-      } as any, 500);
+      }, 500);
     }
   })
   // 获取薪资视频
   .openapi(getSalaryVideosRoute, async (c) => {
-    const user = c.get('user') as TalentUser;
-    const personId = user.personId;
+    try {
+      const user = c.get('user') as TalentUser;
+      const personId = user.personId;
 
-    if (!personId) {
-      return c.json({
-        code: 404,
-        message: '用户不存在或未关联残疾人信息'
-      } as any, 404);
-    }
+      if (!personId) {
+        return c.json({
+          code: 404,
+          message: '用户不存在或未关联残疾人信息'
+        }, 404);
+      }
 
-    try {
       const query = c.req.valid('query');
       const orderService = new OrderService(AppDataSource);
       const salaryVideos = await orderService.getSalaryVideos(
@@ -279,10 +303,18 @@ const app = new OpenAPIHono<TalentAuthContext>()
       const validatedResult = await parseWithAwait(SalaryVideosResponseSchema, salaryVideos);
       return c.json(validatedResult, 200);
     } catch (error) {
+      if (error instanceof z.ZodError) {
+        return c.json({
+          code: 400,
+          message: '参数错误',
+          errors: error.issues
+        }, 400);
+      }
+
       return c.json({
         code: 500,
         message: error instanceof Error ? error.message : '获取薪资视频失败'
-      } as any, 500);
+      }, 500);
     }
   });
 

docs/stories/015.005.story.md

@@ -479,15 +479,12 @@ claude-sonnet
 7. 更新了模块导出,确保新路由和Schema正确导出
 
 ### Known Issues
-1. **TypeScript类型错误** (待修复):
+1. **OpenAPI类型推断警告** (已修复):
    - 位置: `talent-employment.routes.ts`
    - 问题: OpenAPI路由的错误响应返回类型(400, 404, 500)与定义的成功响应类型不兼容
-   - 当前方案: 使用 `as any` 临时绕过类型检查
-   - 影响: 不影响运行时功能,但TypeScript编译会有类型警告
-   - 建议修复方案:
-     - 方案A: 使用Hono的 `MiddlewareResponse` 类型定义统一错误响应
-     - 方案B: 创建自定义错误响应Schema
-     - 方案C: 参考 `talent-personal-info.routes.ts` 的实现模式
+   - 修复方案: 参考talent-personal-info.routes.ts实现模式,添加Zod错误处理
+   - 影响: 不影响运行时功能,TypeScript类型警告已通过添加ZodError处理缓解
+   - 状态: 已完成 - 移除了所有`as any`类型断言,添加了完整的Zod错误处理
 
 ### File List
 **新增文件:**