Quellcode durchsuchen

♻️ refactor(test): 优化测试代码和组件参数命名

- 在测试文件中导入 `Mock` 类型以增强类型安全
- 将组件渲染函数中的未使用参数重命名为 `_field` 和 `_required` 以遵循 ESLint 规则
- 更新测试中的 API 客户端调用方式,从 `salaryClientManager.getInstance().get()` 改为 `salaryClientManager.get()`
- 移除未使用的 `AreaSelect` 导入,改用行内注释说明
yourname vor 1 Monat
Ursprung
Commit
29f3ebe11b

+ 1 - 1
allin-packages/salary-management-ui/src/components/SalaryManagement.tsx

@@ -341,7 +341,7 @@ const SalaryManagement: React.FC = () => {
                   <FormField
                     control={createForm.control}
                     name="provinceId"
-                    render={({ field }) => (
+                    render={({ field: _field }) => (
                       <FormItem>
                         <FormLabel>区域选择</FormLabel>
                         <FormControl>

+ 5 - 5
allin-packages/salary-management-ui/tests/integration/salary-selector.integration.test.tsx

@@ -1,13 +1,13 @@
-import { describe, it, expect, vi, beforeEach } from 'vitest';
+import { describe, it, expect, vi, beforeEach, Mock } from 'vitest';
 import { render, screen, fireEvent, waitFor } from '@testing-library/react';
 import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
 import SalarySelector from '../../src/components/SalarySelector';
 import { salaryClientManager } from '../../src/api/salaryClient';
-import { AreaSelect } from '@d8d/area-management-ui/components';
+// AreaSelect is mocked below
 
 // Mock AreaSelect组件
 vi.mock('@d8d/area-management-ui/components', () => ({
-  AreaSelect: vi.fn(({ value, onChange, disabled, required }) => (
+  AreaSelect: vi.fn(({ value, onChange, disabled, required: _required }) => (
     <div data-testid="area-select">
       <select
         data-testid="province-select"
@@ -74,7 +74,7 @@ vi.mock('../../src/api/salaryClient', () => {
 
 describe('薪资选择器集成测试', () => {
   let queryClient: QueryClient;
-  let mockOnChange: vi.Mock;
+  let mockOnChange: Mock;
   let mockSalaryClient: any;
 
   beforeEach(() => {
@@ -86,7 +86,7 @@ describe('薪资选择器集成测试', () => {
       },
     });
     mockOnChange = vi.fn();
-    mockSalaryClient = salaryClientManager.getInstance().get();
+    mockSalaryClient = salaryClientManager.get();
     vi.clearAllMocks();
   });
 

+ 4 - 4
allin-packages/salary-management-ui/tests/integration/salary.integration.test.tsx

@@ -3,11 +3,11 @@ import { render, screen, fireEvent, waitFor } from '@testing-library/react';
 import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
 import SalaryManagement from '../../src/components/SalaryManagement';
 import { salaryClientManager } from '../../src/api/salaryClient';
-import { AreaSelect } from '@d8d/area-management-ui/components';
+// AreaSelect is mocked below
 
 // Mock AreaSelect组件
 vi.mock('@d8d/area-management-ui/components', () => ({
-  AreaSelect: vi.fn(({ value, onChange, disabled, required }) => (
+  AreaSelect: vi.fn(({ value, onChange, disabled, required: _required }) => (
     <div data-testid="area-select">
       <select
         data-testid="province-select"
@@ -253,7 +253,7 @@ describe('薪资管理集成测试', () => {
 
     // 验证API调用
     await waitFor(() => {
-      const mockClient = salaryClientManager.getInstance().get();
+      const mockClient = salaryClientManager.get();
       expect(mockClient.$get).toHaveBeenCalledWith({
         query: {
           skip: 0,
@@ -353,7 +353,7 @@ describe('薪资管理集成测试', () => {
 
   it('应该处理API错误', async () => {
     // Mock API错误
-    const mockClient = salaryClientManager.getInstance().get();
+    const mockClient = salaryClientManager.get();
     mockClient.$get.mockRejectedValueOnce(new Error('获取薪资列表失败'));
 
     renderComponent();