Переглянути джерело

✅ test(user): 添加用户路由API集成测试

- 新增user.routes.integration.test.ts文件,覆盖用户CRUD操作的测试
- 测试包括用户创建、读取、更新、删除和搜索功能
- 添加重复用户名、无效邮箱等边界情况测试
- 包含基本性能测试,验证列表查询响应时间小于200ms

♻️ refactor(user): 移除代码中已过时的注释

- 删除custom.routes.ts中关于DataSource传入的临时注释
yourname 4 тижнів тому
батько
коміт
781e60a6f3

+ 0 - 1
packages/user-module/src/routes/custom.routes.ts

@@ -157,7 +157,6 @@ const app = new OpenAPIHono()
   .openapi(deleteUserRoute, async (c) => {
     try {
       const { id } = c.req.valid('param');
-      // 注意:这里需要传入 DataSource,暂时留空,等待重构
       const userService = new UserService(AppDataSource);
       const success = await userService.deleteUser(id);
 

+ 327 - 0
packages/user-module/tests/integration/user.routes.integration.test.ts

@@ -0,0 +1,327 @@
+import { describe, it, expect, beforeEach } from 'vitest';
+import { testClient } from 'hono/testing';
+import {
+  IntegrationTestDatabase,
+  setupIntegrationDatabaseHooks,
+  TestDataFactory
+} from '../utils/integration-test-db';
+import { IntegrationTestAssertions } from '../utils/integration-test-utils';
+import { userRoutes } from '../../src/routes';
+import { UserService } from '../../src/services/user.service';
+
+// 设置集成测试钩子
+setupIntegrationDatabaseHooks()
+
+describe('用户路由API集成测试 (使用hono/testing)', () => {
+  let client: ReturnType<typeof testClient<typeof userRoutes>>;
+
+  beforeEach(async () => {
+    // 创建测试客户端
+    client = testClient(userRoutes);
+  });
+
+  describe('用户创建路由测试', () => {
+    it('应该成功创建用户', async () => {
+      const userData = {
+        username: 'testuser_create_route',
+        email: 'testcreate_route@example.com',
+        password: 'TestPassword123!',
+        nickname: 'Test User Route',
+        phone: '13800138001'
+      };
+
+      const response = await client.$post({
+        json: userData
+      });
+
+      // 断言响应
+      expect(response.status).toBe(201);
+      if (response.status === 201) {
+        const responseData = await response.json();
+        expect(responseData).toHaveProperty('id');
+        expect(responseData.username).toBe(userData.username);
+        expect(responseData.email).toBe(userData.email);
+        expect(responseData.nickname).toBe(userData.nickname);
+
+        // 断言数据库中存在用户
+        await IntegrationTestAssertions.expectUserToExist(userData.username);
+      }
+    });
+
+    it('应该拒绝创建重复用户名的用户', async () => {
+      const dataSource = await IntegrationTestDatabase.getDataSource();
+      if (!dataSource) throw new Error('Database not initialized');
+
+      // 先创建一个用户
+      await TestDataFactory.createTestUser(dataSource, {
+        username: 'duplicate_user_route'
+      });
+
+      // 尝试创建相同用户名的用户
+      const userData = {
+        username: 'duplicate_user_route',
+        email: 'different_route@example.com',
+        password: 'TestPassword123!',
+        nickname: 'Test User'
+      };
+
+      const response = await client.$post({
+        json: userData
+      });
+
+      // 应该返回错误
+      expect(response.status).toBe(500);
+      if (response.status === 500) {
+        const responseData = await response.json();
+        expect(responseData.message).toContain('duplicate key');
+      }
+    });
+
+    it('应该拒绝创建无效邮箱的用户', async () => {
+      const userData = {
+        username: 'testuser_invalid_email_route',
+        email: 'invalid-email',
+        password: 'TestPassword123!',
+        nickname: 'Test User'
+      };
+
+      const response = await client.$post({
+        json: userData
+      });
+
+      // 应该返回验证错误或服务器错误
+      expect([400, 500]).toContain(response.status);
+      if (response.status === 400) {
+        const responseData = await response.json();
+        expect(responseData.code).toBe(400);
+      } else if (response.status === 500) {
+        const responseData = await response.json();
+        expect(responseData.message).toBeDefined();
+      }
+    });
+  });
+
+  describe('用户读取路由测试', () => {
+    it('应该成功获取用户列表', async () => {
+      const dataSource = await IntegrationTestDatabase.getDataSource();
+      if (!dataSource) throw new Error('Database not initialized');
+
+      // 创建几个测试用户
+      await TestDataFactory.createTestUser(dataSource, { username: 'user1_route' });
+      await TestDataFactory.createTestUser(dataSource, { username: 'user2_route' });
+
+      const response = await client.$get({
+        query: {}
+      });
+
+      expect(response.status).toBe(200);
+      if (response.status === 200) {
+        const responseData = await response.json();
+        expect(Array.isArray(responseData.data)).toBe(true);
+        expect(responseData.data.length).toBeGreaterThanOrEqual(2);
+      }
+    });
+
+    it('应该成功获取单个用户详情', async () => {
+      const dataSource = await IntegrationTestDatabase.getDataSource();
+      if (!dataSource) throw new Error('Database not initialized');
+
+      const testUser = await TestDataFactory.createTestUser(dataSource, {
+        username: 'testuser_detail_route'
+      });
+
+      const response = await client[':id'].$get({
+        param: { id: testUser.id }
+      });
+
+      expect(response.status).toBe(200);
+      if (response.status === 200) {
+        const responseData = await response.json();
+        expect(responseData.id).toBe(testUser.id);
+        expect(responseData.username).toBe(testUser.username);
+        expect(responseData.email).toBe(testUser.email);
+      }
+    });
+
+    it('应该返回404当用户不存在时', async () => {
+      const response = await client[':id'].$get({
+        param: { id: 999999 }
+      });
+
+      expect(response.status).toBe(404);
+      if (response.status === 404) {
+        const responseData = await response.json();
+        expect(responseData.message).toContain('资源不存在');
+      }
+    });
+  });
+
+  describe('用户更新路由测试', () => {
+    it('应该成功更新用户信息', async () => {
+      const dataSource = await IntegrationTestDatabase.getDataSource();
+      if (!dataSource) throw new Error('Database not initialized');
+
+      const testUser = await TestDataFactory.createTestUser(dataSource, {
+        username: 'testuser_update_route'
+      });
+
+      const updateData = {
+        nickname: 'Updated Name Route',
+        email: 'updated_route@example.com'
+      };
+
+      const response = await client[':id'].$put({
+        param: { id: testUser.id },
+        json: updateData
+      });
+
+      expect(response.status).toBe(200);
+      if (response.status === 200) {
+        const responseData = await response.json();
+        expect(responseData.nickname).toBe(updateData.nickname);
+        expect(responseData.email).toBe(updateData.email);
+      }
+
+      // 验证数据库中的更新
+      const getResponse = await client[':id'].$get({
+        param: { id: testUser.id }
+      });
+      if (getResponse.status === 200) {
+        expect(getResponse.status).toBe(200);
+        const getResponseData = await getResponse.json();
+        expect(getResponseData.nickname).toBe(updateData.nickname);
+      }
+    });
+
+    it('应该返回404当更新不存在的用户时', async () => {
+      const updateData = {
+        nickname: 'Updated Name',
+        email: 'updated@example.com'
+      };
+
+      const response = await client[':id'].$put({
+        param: { id: 999999 },
+        json: updateData
+      });
+
+      expect(response.status).toBe(404);
+      if (response.status === 404) {
+        const responseData = await response.json();
+        expect(responseData.message).toContain('资源不存在');
+      }
+    });
+  });
+
+  describe('用户删除路由测试', () => {
+    it('应该成功删除用户', async () => {
+      const dataSource = await IntegrationTestDatabase.getDataSource();
+      if (!dataSource) throw new Error('Database not initialized');
+
+      const testUser = await TestDataFactory.createTestUser(dataSource, {
+        username: 'testuser_delete_route'
+      });
+
+      const response = await client[':id'].$delete({
+        param: { id: testUser.id }
+      });
+
+      IntegrationTestAssertions.expectStatus(response, 204);
+
+      // 验证用户已从数据库中删除
+      await IntegrationTestAssertions.expectUserNotToExist('testuser_delete_route');
+
+      // 验证再次获取用户返回404
+      const getResponse = await client[':id'].$get({
+        param: { id: testUser.id }
+      });
+      IntegrationTestAssertions.expectStatus(getResponse, 404);
+    });
+
+    it('应该返回404当删除不存在的用户时', async () => {
+      const response = await client[':id'].$delete({
+        param: { id: 999999 }
+      });
+
+      IntegrationTestAssertions.expectStatus(response, 404);
+      if (response.status === 404) {
+        const responseData = await response.json();
+        expect(responseData.message).toContain('资源不存在');
+      }
+    });
+  });
+
+  describe('用户搜索路由测试', () => {
+    it('应该能够按用户名搜索用户', async () => {
+      const dataSource = await IntegrationTestDatabase.getDataSource();
+      if (!dataSource) throw new Error('Database not initialized');
+
+      await TestDataFactory.createTestUser(dataSource, { username: 'search_user_1_route', email: 'search1_route@example.com' });
+      await TestDataFactory.createTestUser(dataSource, { username: 'search_user_2_route', email: 'search2_route@example.com' });
+      await TestDataFactory.createTestUser(dataSource, { username: 'other_user_route', email: 'other_route@example.com' });
+
+      const response = await client.$get({
+        query: { keyword: 'search_user' }
+      });
+
+      IntegrationTestAssertions.expectStatus(response, 200);
+      if (response.status === 200) {
+        const responseData = await response.json();
+        expect(Array.isArray(responseData.data)).toBe(true);
+        expect(responseData.data.length).toBe(2);
+
+        // 验证搜索结果包含正确的用户
+        const usernames = responseData.data.map((user: any) => user.username);
+        expect(usernames).toContain('search_user_1_route');
+        expect(usernames).toContain('search_user_2_route');
+        expect(usernames).not.toContain('other_user_route');
+      }
+    });
+
+    it('应该能够按邮箱搜索用户', async () => {
+      const dataSource = await IntegrationTestDatabase.getDataSource();
+      if (!dataSource) throw new Error('Database not initialized');
+
+      await TestDataFactory.createTestUser(dataSource, { username: 'user_email_1_route', email: 'test.email1_route@example.com' });
+      await TestDataFactory.createTestUser(dataSource, { username: 'user_email_2_route', email: 'test.email2_route@example.com' });
+
+      const response = await client.$get({
+        query: { keyword: 'test.email' }
+      });
+
+      IntegrationTestAssertions.expectStatus(response, 200);
+      if (response.status === 200) {
+        const responseData = await response.json();
+        expect(responseData.data.length).toBe(2);
+
+        const emails = responseData.data.map((user: any) => user.email);
+        expect(emails).toContain('test.email1_route@example.com');
+        expect(emails).toContain('test.email2_route@example.com');
+      }
+    });
+  });
+
+  describe('性能测试', () => {
+    it('用户列表查询响应时间应小于200ms', async () => {
+      const dataSource = await IntegrationTestDatabase.getDataSource();
+      if (!dataSource) throw new Error('Database not initialized');
+
+      // 创建一些测试数据
+      for (let i = 0; i < 10; i++) {
+        await TestDataFactory.createTestUser(dataSource, {
+          username: `perf_user_${i}_route`,
+          email: `perf${i}_route@example.com`
+        });
+      }
+
+      const startTime = Date.now();
+      const response = await client.$get({
+        query: {}
+      });
+      const endTime = Date.now();
+      const responseTime = endTime - startTime;
+
+      IntegrationTestAssertions.expectStatus(response, 200);
+      expect(responseTime).toBeLessThan(200); // 响应时间应小于200ms
+    });
+  });
+});